t/README: justify why "! grep foo" is sufficient
We require use of test_must_fail to check expected non-zero exit by Git itself, but discourage test_must_fail to be used for checking exit status of non Git commands that are supplied by the system. The current text explains the reason for the former but not the latter. Signed-off-by: Junio C Hamano <gitster@pobox.com>
Junio C Hamano committed
Nov 24, 2014 at 09:47 UTC
53de742470bdf160a8412d7a2e9c30545db63fac
1 file changed
+2
-1
t/README
+2
-1
@@ -335,7 +335,8 @@ Don't:
335
dies in an unexpected way (e.g. segfault).
336
337
On the other hand, don't use test_must_fail for running regular
338
- platform commands; just use '! cmd'.
338
+ platform commands; just use '! cmd'. We are not in the business
339
+ of verifying that the world given to us sanely works.
340
341
- use perl without spelling it as "$PERL_PATH". This is to help our
342
friends on Windows where the platform Perl often adds CR before