t9819: don't use test_must_fail with p4
We were using `test_must_fail p4` to test that the p4 command failed as expected. However, test_must_fail() is used to ensure that commands fail in an expected way, not due to something like a segv. Since we are not in the business of verifying the sanity of the external world, replace `test_must_fail p4` with `! p4` and assume that the `p4` command does not die unexpectedly. Signed-off-by: Denton Liu <liu.denton@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Denton Liu committed
Apr 20, 2020 at 04:54 UTC
546f352638fd4fd7e517e8c6e74e229825e9afab
1 file changed
+1
-1
t/t9819-git-p4-case-folding.sh
+1
-1
@@ -30,7 +30,7 @@ test_expect_success 'Check p4 is in case-folding mode' '
30
cd "$cli" &&
31
>lc/FILE.TXT &&
32
p4 add lc/FILE.TXT &&
33
- test_must_fail p4 submit -d "Cannot add file differing only in case" lc/FILE.TXT
33
+ ! p4 submit -d "Cannot add file differing only in case" lc/FILE.TXT
34
)
35
'
36