Let check_preimage() use memset() to initialize "struct checkout"
Every code site except check_preimage() uses either memset() or declares a static instance of "struct checkout" to achieve proper initialization. Lets use memset() instead of explicit initialization of all members here too to be on the safe side in case this structure is expanded someday. Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jens Lehmann committed
Apr 9, 2010 at 22:08 UTC
54fd955c211db6f4a2c91301f792ec9de86eed31
1 file changed
+1
-4
builtin-apply.c
+1
-4
@@ -2824,11 +2824,8 @@ static int check_preimage(struct patch *patch, struct cache_entry **ce, struct s
2824
if (stat_ret < 0) {
2825
struct checkout costate;
2826
/* checkout */
2827
+ memset(&costate, 0, sizeof(costate));
2828
costate.base_dir = "";
2828
- costate.base_dir_len = 0;
2829
- costate.force = 0;
2830
- costate.quiet = 0;
2831
- costate.not_new = 0;
2829
costate.refresh_cache = 1;
2830
if (checkout_entry(*ce, &costate, NULL) ||
2831
lstat(old_name, st))