t1450: check large blob in trailing-garbage test

Commit cce044df7f (fsck: detect trailing garbage in all object types, 2017-01-13) added two tests of trailing garbage in a loose object file: one with a commit and one with a blob. The point of having two is that blobs would follow a different code path that streamed the contents, instead of loading it into a buffer as usual. At the time, merely being a blob was enough to trigger the streaming code path. But since 7ac4f3a007 (fsck: actually fsck blob data, 2018-05-02), we now only stream blobs that are actually large. So since then, the streaming code path is not tested at all for this case. We can restore the original intent of the test by tweaking core.bigFileThreshold to make our small blob seem large. There's no easy way to externally verify that we followed the streaming code path, but I did check before/after using a temporary debug statement. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jeff King committed Oct 30, 2018 at 19:18 UTC 5632baf238c09b2556c92897bcf0d1fc236499ba
1 file changed +2 -2
t/t1450-fsck.sh
+2 -2
@@ -636,13 +636,13 @@ test_expect_success 'fsck detects trailing loose garbage (commit)' '
636 test_i18ngrep "garbage.*$commit" out
637 '
638
639 -test_expect_success 'fsck detects trailing loose garbage (blob)' '
639 +test_expect_success 'fsck detects trailing loose garbage (large blob)' '
640 blob=$(echo trailing | git hash-object -w --stdin) &&
641 file=$(sha1_file $blob) &&
642 test_when_finished "remove_object $blob" &&
643 chmod +w "$file" &&
644 echo garbage >>"$file" &&
645 - test_must_fail git fsck 2>out &&
645 + test_must_fail git -c core.bigfilethreshold=5 fsck 2>out &&
646 test_i18ngrep "garbage.*$blob" out
647 '
648