parse-options: adjust `parse_opt_unknown_cb()`s declared return type
In f41179f16ba2 (parse-options: avoid magic return codes, 2019-01-27), the signature of the low-level parse-opt callback function was changed to return an `enum`. And while the implementations were changed, one declaration was left unchanged, still claiming to return `int`. This can potentially lead to problems, as compilers are free to choose any integral type for an `enum` as long as it can represent all declared values. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Johannes Schindelin committed
May 13, 2019 at 15:43 UTC
567fce1e10e77b39203504ad36a273d447ec031a
1 file changed
+3
-1
parse-options.h
+3
-1
@@ -286,7 +286,9 @@ int parse_opt_commit(const struct option *, const char *, int);
286
int parse_opt_tertiary(const struct option *, const char *, int);
287
int parse_opt_string_list(const struct option *, const char *, int);
288
int parse_opt_noop_cb(const struct option *, const char *, int);
289
-int parse_opt_unknown_cb(struct parse_opt_ctx_t *ctx, const struct option *, const char *, int);
289
+enum parse_opt_result parse_opt_unknown_cb(struct parse_opt_ctx_t *ctx,
290
+ const struct option *,
291
+ const char *, int);
292
int parse_opt_passthru(const struct option *, const char *, int);
293
int parse_opt_passthru_argv(const struct option *, const char *, int);
294