contrib/thunderbird-patch-inline/appp.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Elia Pinto committed
Dec 22, 2015 at 15:10 UTC
57eb1bef7d86507437ebdfa5a855508e6ab05035
1 file changed
+2
-2
contrib/thunderbird-patch-inline/appp.sh
+2
-2
@@ -31,8 +31,8 @@ BODY=$(sed -e "1,/${SEP}/d" $1)
31
CMT_MSG=$(sed -e '1,/^$/d' -e '/^---$/,$d' "${PATCH}")
32
DIFF=$(sed -e '1,/^---$/d' "${PATCH}")
33
34
-CCS=`echo -e "$CMT_MSG\n$HEADERS" | sed -n -e 's/^Cc: \(.*\)$/\1,/gp' \
35
- -e 's/^Signed-off-by: \(.*\)/\1,/gp'`
34
+CCS=$(echo -e "$CMT_MSG\n$HEADERS" | sed -n -e 's/^Cc: \(.*\)$/\1,/gp' \
35
+ -e 's/^Signed-off-by: \(.*\)/\1,/gp')
36
37
echo "$SUBJECT" > $1
38
echo "Cc: $CCS" >> $1