t8001/t8002: blame: demonstrate -L bounds checking bug
A bounds checking bug allows the X in -LX to extend one line past the end of file. For example, given a file with 5 lines, -L6 is accepted as valid. Demonstrate this problem. While here, also add tests to check that the remaining cases of X and Y in -LX,Y are handled correctly at and in the vicinity of end-of-file. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Eric Sunshine committed
Jul 31, 2013 at 04:15 UTC
580b4f3acf076f5f3346206d3c54912ffc663d86
1 file changed
+22
t/annotate-tests.sh
+22
@@ -225,10 +225,32 @@ test_expect_success 'blame -L /RE/,-N' '
225
check_count -L/99/,-3 B 1 B2 1 D 1
226
'
227
228
+# 'file' ends with an incomplete line, so 'wc' reports one fewer lines than
229
+# git-blame sees, hence the last line is actually $(wc...)+1.
230
+test_expect_success 'blame -L X (X == nlines)' '
231
+ n=$(expr $(wc -l <file) + 1) &&
232
+ check_count -L$n C 1
233
+'
234
+
235
+test_expect_failure 'blame -L X (X == nlines + 1)' '
236
+ n=$(expr $(wc -l <file) + 2) &&
237
+ test_must_fail $PROG -L$n file
238
+'
239
+
240
test_expect_success 'blame -L X (X > nlines)' '
241
test_must_fail $PROG -L12345 file
242
'
243
244
+test_expect_success 'blame -L ,Y (Y == nlines)' '
245
+ n=$(expr $(wc -l <file) + 1) &&
246
+ check_count -L,$n A 1 B 1 B1 1 B2 1 "A U Thor" 1 C 1 D 1 E 1
247
+'
248
+
249
+test_expect_success 'blame -L ,Y (Y == nlines + 1)' '
250
+ n=$(expr $(wc -l <file) + 2) &&
251
+ test_must_fail $PROG -L,$n file
252
+'
253
+
254
test_expect_success 'blame -L ,Y (Y > nlines)' '
255
test_must_fail $PROG -L,12345 file
256
'