pack-objects: validation and documentation about unreachable options

These options are added in [1] [2] [3]. All these depend on running rev-list internally which is normally true since they are always used with "--all --objects" which implies --revs. But let's keep this dependency explicit. While at there, add documentation for them. These are mostly used internally by git-repack. But it's still good to not chase down the right commit message to know how they work. [1] ca11b212eb (let pack-objects do the writing of unreachable objects as loose objects - 2008-05-14) [2] 08cdfb1337 (pack-objects --keep-unreachable - 2007-09-16) [3] e26a8c4721 (repack: extend --keep-unreachable to loose objects - 2016-06-13) Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Reviewed-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Nguyễn Thái Ngọc Duy committed May 5, 2018 at 10:47 UTC 58bd77b66a83e7d8bcbc4e756ab997416d246be2
2 files changed +15
Documentation/git-pack-objects.txt
+13
@@ -267,6 +267,19 @@ Unexpected missing object will raise an error.
267 locally created objects [without .promisor] and objects from the
268 promisor remote [with .promisor].) This is used with partial clone.
269
270 +--keep-unreachable::
271 + Objects unreachable from the refs in packs named with
272 + --unpacked= option are added to the resulting pack, in
273 + addition to the reachable objects that are not in packs marked
274 + with *.keep files. This implies `--revs`.
275 +
276 +--pack-loose-unreachable::
277 + Pack unreachable loose objects (and their loose counterparts
278 + removed). This implies `--revs`.
279 +
280 +--unpack-unreachable::
281 + Keep unreachable objects in loose form. This implies `--revs`.
282 +
283 SEE ALSO
284 --------
285 linkgit:git-rev-list[1]
builtin/pack-objects.c
+2
@@ -3087,6 +3087,8 @@ int cmd_pack_objects(int argc, const char **argv, const char *prefix)
3087 fetch_if_missing = 0;
3088 argv_array_push(&rp, "--exclude-promisor-objects");
3089 }
3090 + if (unpack_unreachable || keep_unreachable || pack_loose_unreachable)
3091 + use_internal_rev_list = 1;
3092
3093 if (!reuse_object)
3094 reuse_delta = 0;