cocci: sort "the_repository" rules by header

Sort the "the_repository.pending.cocci" file by which header the macros are in, and add a comment to that effect in front of the rules. This will make subsequent commits easier to follow, as we'll be applying these rules on a header-by-header basis. Once we've fully applied "the_repository.pending.cocci" we'll keep this rules around for a while in "the_repository.cocci", to help any outstanding topics and out-of-tree code to resolve textual or semantic conflicts with these changes, but eventually we'll remove the "the_repository.cocci" as a follow-up. So even if some of these functions are subsequently moved and/or split into other or new headers there's no risk of this becoming stale, if and when that happens the we should be removing these rules anyway. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Ævar Arnfjörð Bjarmason committed Mar 28, 2023 at 15:58 UTC 5978de20319602ae18d2b8241aa6f59f3f04f198
1 file changed +19 -15
contrib/coccinelle/the_repository.pending.cocci
+19 -15
@@ -5,21 +5,7 @@
5 @@
6 @@
7 (
8 -- read_object_file
9 -+ repo_read_object_file
10 -|
11 -- has_object_file
12 -+ repo_has_object_file
13 -|
14 -- has_object_file_with_flags
15 -+ repo_has_object_file_with_flags
16 -|
17 -- parse_commit_internal
18 -+ repo_parse_commit_internal
19 -|
20 -- parse_commit
21 -+ repo_parse_commit
22 -|
8 +// commit-reach.h
9 - get_merge_bases
10 + repo_get_merge_bases
11 |
@@ -34,6 +20,13 @@
20 |
21 - in_merge_bases_many
22 + repo_in_merge_bases_many
23 +// commit.h
24 +|
25 +- parse_commit_internal
26 ++ repo_parse_commit_internal
27 +|
28 +- parse_commit
29 ++ repo_parse_commit
30 |
31 - get_commit_buffer
32 + repo_get_commit_buffer
@@ -43,6 +36,17 @@
36 |
37 - logmsg_reencode
38 + repo_logmsg_reencode
39 +// object-store.h
40 +|
41 +- read_object_file
42 ++ repo_read_object_file
43 +|
44 +- has_object_file
45 ++ repo_has_object_file
46 +|
47 +- has_object_file_with_flags
48 ++ repo_has_object_file_with_flags
49 +// pretty.h
50 |
51 - format_commit_message
52 + repo_format_commit_message