@matheusbsbs / matheus-bagliano / commits / 598df7bcb7
Fork 0

t/gitweb-lib: Don't pass constant to decode_utf8

Encode.pm started updating the string to decode in-place when a second argument is passed in version 2.40. This causes 'decode_utf8("", Encode::FB_CROAK)' to die with a message like: Modification of a read-only value attempted at .../Encode.pm line 216. Work around this by passing an empty variable instead of a constant string. Signed-off-by: Brian Gernhardt <brian@gernhardtsoftware.com> Acked-by: Jakub Narebski <jnareb@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Brian Gernhardt committed Oct 20, 2010 at 01:57 UTC 598df7bcb775a247cc3f20c5a8b1b36955b16462
1 file changed +1 -1
t/gitweb-lib.sh
+1 -1
@@ -80,7 +80,7 @@ if ! test_have_prereq PERL; then
80 test_done
81 fi
82
83 -perl -MEncode -e 'decode_utf8("", Encode::FB_CROAK)' >/dev/null 2>&1 || {
83 +perl -MEncode -e '$e="";decode_utf8($e, Encode::FB_CROAK)' >/dev/null 2>&1 || {
84 skip_all='skipping gitweb tests, perl version is too old'
85 test_done
86 }