@matheusbsbs / matheus-bagliano / commits / 59b2829ec5
Fork 0

pack-bitmap: uninteresting oid can be outside bitmapped packfile

bitmap_has_oid_in_uninteresting() only used bitmap_position_packfile(), not bitmap_position(). So it wouldn't find objects which weren't in the bitmapped packfile (i.e., ones where we extended the bitmap to handle loose objects, or objects in other packs). As we could reuse a delta against such an object it is suboptimal not to use bitmap_position(), so let's use it instead of bitmap_position_packfile(). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jeff King committed Dec 18, 2019 at 12:25 UTC 59b2829ec535b6c33edc32526ddb9b9b7e86a5a3
1 file changed +1 -1
pack-bitmap.c
+1 -1
@@ -1139,7 +1139,7 @@ int bitmap_has_oid_in_uninteresting(struct bitmap_index *bitmap_git,
1139 if (!bitmap_git->haves)
1140 return 0; /* walk had no "haves" */
1141
1142 - pos = bitmap_position_packfile(bitmap_git, oid);
1142 + pos = bitmap_position(bitmap_git, oid);
1143 if (pos < 0)
1144 return 0;
1145