lib-credential.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Elia Pinto committed
Apr 23, 2014 at 06:44 UTC
5a4352024ae71613186730e3a3ab670f43904ad6
1 file changed
+1
-1
t/lib-credential.sh
+1
-1
@@ -281,7 +281,7 @@ helper_test_timeout() {
281
cat >askpass <<\EOF
282
#!/bin/sh
283
echo >&2 askpass: $*
284
-what=`echo $1 | cut -d" " -f1 | tr A-Z a-z | tr -cd a-z`
284
+what=$(echo $1 | cut -d" " -f1 | tr A-Z a-z | tr -cd a-z)
285
echo "askpass-$what"
286
EOF
287
chmod +x askpass