gitk: Fix bug causing Tcl error when no commits are selected
Some of the stuff that commit 31c0eaa8cc10944ebca8aa31fb59f0b77b1b6e77 added to drawvisible isn't appropriate to do when we have no commits, and this was causing a Tcl error if gitk was invoked in such a fashion that no commits were selected. This fixes it by bailing out of drawvisible early if there are no commits displayed. Bug reported by Johannes Sixt. Signed-off-by: Paul Mackerras <paulus@samba.org>
Paul Mackerras committed
Jan 15, 2008 at 22:45 UTC
5a7f577dcedeff60e5267fd9efbfb05987a359e4
1 file changed
+1
-1
gitk
+1
-1
@@ -4573,7 +4573,7 @@ proc drawvisible {} {
4573
4574
set fs [$canv yview]
4575
set ymax [lindex [$canv cget -scrollregion] 3]
4576
- if {$ymax eq {} || $ymax == 0} return
4576
+ if {$ymax eq {} || $ymax == 0 || $numcommits == 0} return
4577
set f0 [lindex $fs 0]
4578
set f1 [lindex $fs 1]
4579
set y0 [expr {int($f0 * $ymax)}]