t5550: simplify no matching line check
In the 'did not use upload-pack service' test, we have a complicated song-and-dance to ensure that there are no "/git-upload-pack" lines in "$HTTPD_ROOT_PATH/access.log". Simplify this by just checking that grep returns a non-zero exit code. Helped-by: Junio C Hamano <gitster@pobox.com> Signed-off-by: Denton Liu <liu.denton@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Denton Liu committed
Mar 26, 2020 at 04:27 UTC
5a828bcf1e1a3152f31c90bcf6557ba8d7b0459f
1 file changed
+1
-3
t/t5550-http-fetch-dumb.sh
+1
-3
@@ -248,9 +248,7 @@ test_expect_success 'fetch can handle previously-fetched .idx files' '
248
'
249
250
test_expect_success 'did not use upload-pack service' '
251
- test_might_fail grep '/git-upload-pack' <"$HTTPD_ROOT_PATH"/access.log >act &&
252
- : >exp &&
253
- test_cmp exp act
251
+ ! grep "/git-upload-pack" "$HTTPD_ROOT_PATH/access.log"
252
'
253
254
test_expect_success 'git client shows text/plain errors' '