@matheusbsbs / matheus-bagliano / commits / 5a85a25e35
Fork 0

t5512: don't use `test_must_fail test_cmp`

The test_must_fail function should only be used for git commands since we should assume that external commands work sanely. Since test_cmp() just wraps an external command, replace `test_must_fail test_cmp` with `! test_cmp`. Signed-off-by: Denton Liu <liu.denton@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Denton Liu committed Mar 25, 2020 at 01:54 UTC 5a85a25e3528cf94a89861800eb4b939408792e3
1 file changed +1 -1
t/t5512-ls-remote.sh
+1 -1
@@ -92,7 +92,7 @@ test_expect_success 'use "origin" when no remote specified' '
92
93 test_expect_success 'suppress "From <url>" with -q' '
94 git ls-remote -q 2>actual_err &&
95 - test_must_fail test_cmp exp_err actual_err
95 + ! test_cmp exp_err actual_err
96 '
97
98 test_expect_success 'use branch.<name>.remote if possible' '