@matheusbsbs / matheus-bagliano / commits / 5b88caa417

run_external_diff: drop fflush(NULL)

This fflush was added in d5535ec (Use run_command() to spawn external diff programs instead of fork/exec., 2007-10-19), because flushing buffers before forking is a good habit. But later, 7d0b18a (Add output flushing before fork(), 2008-08-04) added it to the generic run-command interface, meaning that our flush here is redundant. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jeff King committed Apr 19, 2014 at 15:19 UTC 5b88caa417ab221c8f8576332fba8d41dd3986d7

1 file changed -1

diff.c

-1

@@ -2932,7 +2932,6 @@ static void run_external_diff(const char *pgm,

2932 argv_array_push(&argv, pgm);

2933 argv_array_push(&argv, name);

2934 }

2935 - fflush(NULL);

2935

2936 argv_array_pushf(&env, "GIT_DIFF_PATH_COUNTER=%d", ++o->diff_path_counter);

2937 argv_array_pushf(&env, "GIT_DIFF_PATH_TOTAL=%d", q->nr);