commit: create get_commit_tree() method
While walking the commit graph, we load struct commit objects into the object cache. During this process, we also load struct tree objects for the root tree of each of these commits. We load these objects even if we are only computing commit reachability information, such as a merge base or ahead/behind information. Create get_commit_tree() as a first step to removing direct references to the 'maybe_tree' member of struct commit. Create get_commit_tree_oid() as a shortcut for several references to "&commit->maybe_tree->object.oid" in the codebase. Signed-off-by: Derrick Stolee <dstolee@microsoft.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Derrick Stolee committed
Apr 6, 2018 at 19:09 UTC
5bb03de102b40d9e564be3a3a39084a550db79cb
2 files changed
+13
commit.c
+10
@@ -296,6 +296,16 @@ void free_commit_buffer(struct commit *commit)
296
}
297
}
298
299
+struct tree *get_commit_tree(const struct commit *commit)
300
+{
301
+ return commit->maybe_tree;
302
+}
303
+
304
+struct object_id *get_commit_tree_oid(const struct commit *commit)
305
+{
306
+ return &get_commit_tree(commit)->object.oid;
307
+}
308
+
309
const void *detach_commit_buffer(struct commit *commit, unsigned long *sizep)
310
{
311
struct commit_buffer *v = buffer_slab_peek(&buffer_slab, commit);
commit.h
+3
@@ -102,6 +102,9 @@ void unuse_commit_buffer(const struct commit *, const void *buffer);
102
*/
103
void free_commit_buffer(struct commit *);
104
105
+struct tree *get_commit_tree(const struct commit *);
106
+struct object_id *get_commit_tree_oid(const struct commit *);
107
+
108
/*
109
* Disassociate any cached object buffer from the commit, but do not free it.
110
* The buffer (or NULL, if none) is returned.