bundle: use leak_pending flag
Instead of creating a copy of the list of pending objects, copy the struct object_array that points to it, turn on leak_pending, and thus cause prepare_revision_walk to leave it to us. And free it once we're done. Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx> Signed-off-by: Junio C Hamano <gitster@pobox.com>
René Scharfe committed
Oct 1, 2011 at 18:02 UTC
5be7859962585589f374f8467f3252bfcfa10fd0
1 file changed
+3
-5
bundle.c
+3
-5
@@ -122,11 +122,8 @@ int verify_bundle(struct bundle_header *header, int verbose)
122
req_nr = revs.pending.nr;
123
setup_revisions(2, argv, &revs, NULL);
124
125
- memset(&refs, 0, sizeof(struct object_array));
126
- for (i = 0; i < revs.pending.nr; i++) {
127
- struct object_array_entry *e = revs.pending.objects + i;
128
- add_object_array(e->item, e->name, &refs);
129
- }
125
+ refs = revs.pending;
126
+ revs.leak_pending = 1;
127
128
if (prepare_revision_walk(&revs))
129
die("revision walk setup failed");
@@ -146,6 +143,7 @@ int verify_bundle(struct bundle_header *header, int verbose)
143
144
for (i = 0; i < refs.nr; i++)
145
clear_commit_marks((struct commit *)refs.objects[i].item, -1);
146
+ free(refs.objects);
147
148
if (verbose) {
149
struct ref_list *r;