serve.c: move version line to advertise_capabilities()
The advertise_capabilities() is only called from serve() and we always emit this version line before it. In a subsequent commit I'll make builtin/upload-pack.c sometimes call advertise_capabilities() directly, so it'll make sense to have this line emitted by advertise_capabilities(), not serve() itself. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Ævar Arnfjörð Bjarmason committed
Aug 5, 2021 at 03:25 UTC
5befe8a1f14e2429fee526acc8dcc23039f5193b
1 file changed
+3
-3
serve.c
+3
-3
@@ -112,6 +112,9 @@ static void advertise_capabilities(void)
112
struct strbuf value = STRBUF_INIT;
113
int i;
114
115
+ /* serve by default supports v2 */
116
+ packet_write_fmt(1, "version 2\n");
117
+
118
for (i = 0; i < ARRAY_SIZE(capabilities); i++) {
119
struct protocol_capability *c = &capabilities[i];
120
@@ -304,9 +307,6 @@ static int process_request(void)
307
void serve(struct serve_options *options)
308
{
309
if (options->advertise_capabilities || !options->stateless_rpc) {
307
- /* serve by default supports v2 */
308
- packet_write_fmt(1, "version 2\n");
309
-
310
advertise_capabilities();
311
/*
312
* If only the list of capabilities was requested exit