setup_git_directory(): handle UNC root paths correctly

When working in the root directory of a file share (this is only possible in Git Bash and Powershell, but not in CMD), the current directory is reported without a trailing slash. This is different from Unix and standard Windows directories: both / and C:\ are reported with a trailing slash as current directories. If a Git worktree is located there, Git is not quite prepared for that: while it does manage to find the .git directory/file, it returns as length of the top-level directory's path *one more* than the length of the current directory, and setup_git_directory_gently() would then return an undefined string as prefix. In practice, this undefined string usually points to NUL bytes, and does not cause much harm. Under rare circumstances that are really involved to reproduce (and not reliably so), the reported prefix could be a suffix string of Git's exec path, though. A careful analysis determined that this bug is unlikely to be exploitable, therefore we mark this as a regular bug fix. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Johannes Schindelin committed Aug 24, 2019 at 15:10 UTC 5cf7b3b1acf2e603d92132906bc6929141172d4c
1 file changed +1 -1
setup.c
+1 -1
@@ -797,7 +797,7 @@ static const char *setup_discovered_git_dir(const char *gitdir,
797 set_git_dir(gitdir);
798 inside_git_dir = 0;
799 inside_work_tree = 1;
800 - if (offset == cwd->len)
800 + if (offset >= cwd->len)
801 return NULL;
802
803 /* Make "offset" point past the '/' (already the case for root dirs) */