gitweb: avoid undefined value warning in print_page_path
The function unconditionally tried to match $type but some callers did not pass it. Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano committed
Jul 31, 2006 at 21:00 UTC
5d1acf4da0d22d73c6b5d70887003d8fa7642ecc
1 file changed
+3
-3
gitweb/gitweb.cgi
+3
-3
@@ -1035,7 +1035,7 @@ sub git_print_page_path {
1035
1036
if (!defined $name) {
1037
print "<div class=\"page_path\"><b>/</b></div>\n";
1038
- } elsif ($type =~ "blob") {
1038
+ } elsif (defined $type && $type eq 'blob') {
1039
print "<div class=\"page_path\"><b>" .
1040
$cgi->a({-href => "$my_uri?" . esc_param("p=$project;a=blob_plain;f=$file_name")}, esc_html($name)) . "</b><br/></div>\n";
1041
} else {
@@ -1550,7 +1550,7 @@ sub git_blame {
1550
" | " . $cgi->a({-href => "$my_uri?" . esc_param("p=$project;a=blame;f=$file_name")}, "head");
1551
git_page_nav('','', $hash_base,$co{'tree'},$hash_base, $formats_nav);
1552
git_header_div('commit', esc_html($co{'title'}), $hash_base);
1553
- git_print_page_path($file_name);
1553
+ git_print_page_path($file_name, 'blob');
1554
print "<div class=\"page_body\">\n";
1555
print <<HTML;
1556
<table class="blame">
@@ -1773,7 +1773,7 @@ sub git_tree {
1773
if (defined $file_name) {
1774
$base = esc_html("$file_name/");
1775
}
1776
- git_print_page_path($file_name);
1776
+ git_print_page_path($file_name, 'tree');
1777
print "<div class=\"page_body\">\n";
1778
print "<table cellspacing=\"0\">\n";
1779
my $alternate = 0;