@matheusbsbs / matheus-bagliano / commits / 5d29275638
Fork 0

shell-scripts usage(): consistently exit with non-zero

Earlier conversion of shell scripts to parse-options made usage() to run "git cmd -h" which in turn emit LONG_USAGE and exit with 0 status. This is inconsistent with the scripts that do not use parse-options, whose usage() died with the message, exiting with 1. Signed-off-by: Junio C Hamano <gitster@pobox.com>

Junio C Hamano committed Dec 20, 2007 at 12:58 UTC 5d29275638f48ee442202f0c478d1d8b9d396cc6
1 file changed +2 -1
git-sh-setup.sh
+2 -1
@@ -18,7 +18,8 @@ die() {
18
19 if test -n "$OPTIONS_SPEC"; then
20 usage() {
21 - exec "$0" -h
21 + "$0" -h
22 + exit 1
23 }
24
25 parseopt_extra=