t1301: use test_when_finished for cleanup

Refactor several test cases to use "test_when_finished" for cleanup. 1. For first of these, we used to clean-up outside the test, but instead let's use test_when_finished for that. 2. For the second, we used to leave "new" after we are done, but not use it at all later. Now we do clean up. 3. For the rest, these child.git test repositories used to follow "initialize what we are going to use to a known state before we use" pattern, which is not wrong per-se, but now we use "clean up the cruft we made after we are done" pattern, which may arguably be better simply because the test that makes cruft should know what cruft it created better than whatever comes later that may not know. Helped-by: Junio C Hamano <gitster@pobox.com> Signed-off-by: Jiang Xin <zhiyou.jx@alibaba-inc.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jiang Xin committed Nov 29, 2022 at 21:15 UTC 5d64229ef5a98537bdea20faadfb5cf54ed077f7
1 file changed +5 -3
t/t1301-shared-repo.sh
+5 -3
@@ -25,6 +25,7 @@ test_expect_success 'shared = 0400 (faulty permission u-w)' '
25 for u in 002 022
26 do
27 test_expect_success POSIXPERM "shared=1 does not clear bits preset by umask $u" '
28 + test_when_finished "rm -rf sub" &&
29 mkdir sub && (
30 cd sub &&
31 umask $u &&
@@ -42,7 +43,6 @@ do
43 ;;
44 esac
45 '
45 - rm -rf sub
46 done
47
48 test_expect_success 'shared=all' '
@@ -132,6 +132,7 @@ test_expect_success POSIXPERM 'git reflog expire honors core.sharedRepository' '
132 '
133
134 test_expect_success POSIXPERM 'forced modes' '
135 + test_when_finished "rm -rf new" &&
136 mkdir -p templates/hooks &&
137 echo update-server-info >templates/hooks/post-update &&
138 chmod +x templates/hooks/post-update &&
@@ -174,6 +175,7 @@ test_expect_success POSIXPERM 'forced modes' '
175 '
176
177 test_expect_success POSIXPERM 'remote init does not use config from cwd' '
178 + test_when_finished "rm -rf child.git" &&
179 git config core.sharedrepository 0666 &&
180 umask 0022 &&
181 git init --bare child.git &&
@@ -193,7 +195,7 @@ test_expect_success POSIXPERM 're-init respects core.sharedrepository (local)' '
195 '
196
197 test_expect_success POSIXPERM 're-init respects core.sharedrepository (remote)' '
196 - rm -rf child.git &&
198 + test_when_finished "rm -rf child.git" &&
199 umask 0022 &&
200 git init --bare --shared=0666 child.git &&
201 test_path_is_missing child.git/foo &&
@@ -204,7 +206,7 @@ test_expect_success POSIXPERM 're-init respects core.sharedrepository (remote)'
206 '
207
208 test_expect_success POSIXPERM 'template can set core.sharedrepository' '
207 - rm -rf child.git &&
209 + test_when_finished "rm -rf child.git" &&
210 umask 0022 &&
211 git config core.sharedrepository 0666 &&
212 cp .git/config templates/config &&