t5551: do not use unportable sed '\+'
The set-up step to prepare a repository with 50000 tags used a non-porable '\+' to match one-or-more. The error was not caught because the next test that uses that repository did not even bother to check if these expected tags were actually cloned to the resulting repository. Fix the sed construct to use BRE and update the "clone" test that wanted to test cloning from such a repository with many refs to check the resulting repository. Signed-off-by: Junio C Hamano <gitster@pobox.com>
Junio C Hamano committed
May 12, 2013 at 15:50 UTC
5e2c7cd2c124da05d1807d5ffe61b2771bb755ee
1 file changed
+6
-2
t/t5551-http-fetch.sh
+6
-2
@@ -184,13 +184,17 @@ test_expect_success EXPENSIVE 'create 50,000 tags in the repo' '
184
185
# now assign tags to all the dangling commits we created above
186
tag=$("$PERL_PATH" -e "print \"bla\" x 30") &&
187
- sed -e "s/^:\(.\+\) \(.\+\)$/\2 refs\/tags\/$tag-\1/" <marks >>packed-refs
187
+ sed -e "s|^:\([^ ]*\) \(.*\)$|\2 refs/tags/$tag-\1|" <marks >>packed-refs
188
)
189
'
190
191
test_expect_success EXPENSIVE 'clone the 50,000 tag repo to check OS command line overflow' '
192
git clone $HTTPD_URL/smart/repo.git too-many-refs 2>err &&
193
- test_line_count = 0 err
193
+ test_line_count = 0 err &&
194
+ (
195
+ cd too-many-refs &&
196
+ test $(git for-each-ref refs/tags | wc -l) = 50000
197
+ )
198
'
199
200
stop_httpd