strbuf: remove unreferenced strbuf_write_fd method.
strbuf_write_fd was only used in bugreport.c. Since that file now uses write_in_full, this method is no longer needed. In addition, strbuf_write_fd did not guard against exceeding MAX_IO_SIZE for the platform, nor provided error handling in the event of a failure if only partial data was written to the file descriptor. Since already write_in_full has this capability and is in general use, it should be used instead. The change impacts strbuf.c and strbuf.h. Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Randall S. Becker committed
Jun 19, 2020 at 16:23 UTC
5f2b643e76d9a1330c1a02489c0787ca7d818633
2 files changed
-6
strbuf.c
-5
@@ -539,11 +539,6 @@ ssize_t strbuf_write(struct strbuf *sb, FILE *f)
539
return sb->len ? fwrite(sb->buf, 1, sb->len, f) : 0;
540
}
541
542
-ssize_t strbuf_write_fd(struct strbuf *sb, int fd)
543
-{
544
- return sb->len ? write(fd, sb->buf, sb->len) : 0;
545
-}
546
-
542
#define STRBUF_MAXLINK (2*PATH_MAX)
543
544
int strbuf_readlink(struct strbuf *sb, const char *path, size_t hint)
strbuf.h
-1
@@ -450,7 +450,6 @@ int strbuf_readlink(struct strbuf *sb, const char *path, size_t hint);
450
* NUL bytes.
451
*/
452
ssize_t strbuf_write(struct strbuf *sb, FILE *stream);
453
-ssize_t strbuf_write_fd(struct strbuf *sb, int fd);
453
454
/**
455
* Read a line from a FILE *, overwriting the existing contents of