sequencer: make sign_off_header a file local symbol
Commit d0aaa46fd3 ("commit: move empty message checks to libgit", 2017-11-10) removes the last use of 'sign_off_header' outside of the "sequencer.c" source file. Remove the extern declaration from the header file and mark the definition of the symbol with the static keyword. Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Ramsay Jones committed
Feb 11, 2019 at 17:16 UTC
5fe81438b52f8464947e5b27381a898d7451260e
2 files changed
+1
-3
sequencer.c
+1
-1
@@ -31,7 +31,7 @@
31
32
#define GIT_REFLOG_ACTION "GIT_REFLOG_ACTION"
33
34
-const char sign_off_header[] = "Signed-off-by: ";
34
+static const char sign_off_header[] = "Signed-off-by: ";
35
static const char cherry_picked_prefix[] = "(cherry picked from commit ";
36
37
GIT_PATH_FUNC(git_path_commit_editmsg, "COMMIT_EDITMSG")
sequencer.h
-2
@@ -83,8 +83,6 @@ int check_todo_list(void);
83
int skip_unnecessary_picks(void);
84
int rearrange_squash(void);
85
86
-extern const char sign_off_header[];
87
-
86
void append_signoff(struct strbuf *msgbuf, int ignore_footer, unsigned flag);
87
void append_conflicts_hint(struct strbuf *msgbuf);
88
int message_is_empty(const struct strbuf *sb,