clone: prevent --reference to a shallow repository
If we borrow objects from another repository, we should also pay attention to their $GIT_DIR/shallow (and even info/grafts). But current alternates code does not. Reject alternate repos that are shallow because we do not do it right. In future the alternate code may be updated to check $GIT_DIR/shallow properly so that this restriction could be lifted. Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Nguyễn Thái Ngọc Duy committed
Dec 5, 2013 at 20:02 UTC
606e435a0a11634744282068174240caf2926fec
1 file changed
+6
builtin/clone.c
+6
@@ -252,6 +252,12 @@ static int add_one_reference(struct string_list_item *item, void *cb_data)
252
die(_("reference repository '%s' is not a local repository."),
253
item->string);
254
255
+ if (!access(mkpath("%s/shallow", ref_git), F_OK))
256
+ die(_("reference repository '%s' is shallow"), item->string);
257
+
258
+ if (!access(mkpath("%s/info/grafts", ref_git), F_OK))
259
+ die(_("reference repository '%s' is grafted"), item->string);
260
+
261
strbuf_addf(&alternate, "%s/objects", ref_git);
262
add_to_alternates_file(alternate.buf);
263
strbuf_release(&alternate);