Change the initialization of "struct strbuf" changed in
cbc0f81d96f (strbuf: use designated initializers in STRBUF_INIT,
2017-07-10) to omit specifying "alloc" and "len", as we do with other
"alloc" and "len" (or "nr") in similar structs.
Let's likewise omit the explicit initialization of all fields in the
"struct ipc_client_connect_option" struct added in
59c7b88198a (simple-ipc: add win32 implementation, 2021-03-15).
Do the same for a few other initializers, e.g. STRVEC_INIT and
CACHE_DEF_INIT.
Finally, start incrementally changing the same pattern in
"t/helper/test-run-command.c". This change was part of an earlier
on-list version[1] of c90be786da9 (test-tool run-command: fix
flip-flop init pattern, 2021-09-11).
1. https://lore.kernel.org/git/patch-1.1-0aa4523ab6e-20210909T130849Z-avarab@gmail.com/
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Ævar Arnfjörð Bjarmason committedSep 27, 2021 at 14:54 UTC608cfd31cf8179ff971ddaf64675b47187e768c7
index 2c48a5ee00..08b2908d5f 100644--- a/simple-ipc.h+++ b/simple-ipc.h@@ -65,11 +65,7 @@ struct ipc_client_connect_options { unsigned int uds_disallow_chdir:1; };-#define IPC_CLIENT_CONNECT_OPTIONS_INIT { \- .wait_if_busy = 0, \- .wait_if_not_found = 0, \- .uds_disallow_chdir = 0, \-}+#define IPC_CLIENT_CONNECT_OPTIONS_INIT { 0 } /* * Determine if a server is listening on this named pipe or socket using
strbuf.h
+1-1
index 5b1113abf8..3b36bbc49f 100644--- a/strbuf.h+++ b/strbuf.h@@ -70,7 +70,7 @@ struct strbuf { }; extern char strbuf_slopbuf[];-#define STRBUF_INIT { .alloc = 0, .len = 0, .buf = strbuf_slopbuf }+#define STRBUF_INIT { .buf = strbuf_slopbuf } /* * Predeclare this here, since cache.h includes this file before it defines the
strvec.h
+1-1
index 6b3cbd6758..a10aad5f64 100644--- a/strvec.h+++ b/strvec.h@@ -33,7 +33,7 @@ struct strvec { size_t alloc; };-#define STRVEC_INIT { empty_strvec, 0, 0 }+#define STRVEC_INIT { empty_strvec } /** * Initialize an array. This is no different than assigning from
submodule.h
+1-1
index 4578e501b8..35d18c7868 100644--- a/submodule.h+++ b/submodule.h@@ -37,7 +37,7 @@ struct submodule_update_strategy { enum submodule_update_type type; const char *command; };-#define SUBMODULE_UPDATE_STRATEGY_INIT {SM_UPDATE_UNSPECIFIED, NULL}+#define SUBMODULE_UPDATE_STRATEGY_INIT {SM_UPDATE_UNSPECIFIED} int is_gitmodules_unmerged(struct index_state *istate); int is_writing_gitmodules_ok(void);