git-cvsexportcommit: support Perl before 5.10.1
The change in 6e9c4d408d ("git-cvsexportcommit: port to SHA-256", 2020-06-22) added the use of a temporary directory for the index. However, the form we used doesn't work in versions of Perl before 5.10.1. For example, version 5.10.0 contains a version of File::Temp from 2007 that doesn't contain "newdir". In order to make the code work with 5.8.8, which we support, let's change to use the static method "tempdir" with the argument "CLEANUP", which provides the same behavior. Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
brian m. carlson committed
Aug 6, 2020 at 00:16 UTC
6103d58b7fa335b5f26281ad2c3c90de5680a0c4
1 file changed
+1
-1
git-cvsexportcommit.perl
+1
-1
@@ -22,7 +22,7 @@ die "Need at least one commit identifier!" unless @ARGV;
22
my $repo = Git->repository();
23
$opt_w = $repo->config('cvsexportcommit.cvsdir') unless defined $opt_w;
24
25
-my $tmpdir = File::Temp->newdir;
25
+my $tmpdir = File::Temp::tempdir(CLEANUP => 1);
26
my $hash_algo = $repo->config('extensions.objectformat') || 'sha1';
27
my $hexsz = $hash_algo eq 'sha256' ? 64 : 40;
28