repo_logmsg_reencode: fix memory leak when use repo_logmsg_reencode ()
pretty.c:repo_logmsg_reencode() allocated memory should be freed with repo_unuse_commit_buffer(). Callers sometimes forgot free it at exit point. Add `repo_unuse_commit_buffer()` in insert_records_from_trailers at builtin/shortlog.c and create_commit at builtin/replay.c Signed-off-by: Lidong Yan <502024330056@smail.nju.edu.cn> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Lidong Yan committed
Jun 5, 2025 at 06:27 UTC
61372dd613b1715af439a02129ea08a2c30e212e
2 files changed
+3
-1
builtin/replay.c
+1
@@ -84,6 +84,7 @@ static struct commit *create_commit(struct repository *repo,
84
obj = parse_object(repo, &ret);
85
86
out:
87
+ repo_unuse_commit_buffer(the_repository, based_on, message);
88
free_commit_extra_headers(extra);
89
free_commit_list(parents);
90
strbuf_release(&msg);
builtin/shortlog.c
+2
-1
@@ -187,7 +187,7 @@ static void insert_records_from_trailers(struct shortlog *log,
187
ctx->output_encoding);
188
body = strstr(commit_buffer, "\n\n");
189
if (!body)
190
- return;
190
+ goto out;
191
192
trailer_iterator_init(&iter, body);
193
while (trailer_iterator_advance(&iter)) {
@@ -206,6 +206,7 @@ static void insert_records_from_trailers(struct shortlog *log,
206
}
207
trailer_iterator_release(&iter);
208
209
+out:
210
strbuf_release(&ident);
211
repo_unuse_commit_buffer(the_repository, commit, commit_buffer);
212
}