sha1_name: avoid unnecessary sha1 lookup in find_unique_abbrev
An example where this happens is when doing an ls-tree on a tree that contains a commit link. In that case, find_unique_abbrev is called to get a non-abbreviated hex sha1, but still, a lookup is done as to whether the sha1 is in the repository (which ends up looking for a loose object in .git/objects), while the result of that lookup is not used when returning a non-abbreviated hex sha1. Signed-off-by: Mike Hommey <mh@glandium.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Mike Hommey committed
Nov 26, 2014 at 19:12 UTC
61e704e38a4c3e181403a766c5cf28814e4102e4
1 file changed
+1
-1
sha1_name.c
+1
-1
@@ -373,10 +373,10 @@ const char *find_unique_abbrev(const unsigned char *sha1, int len)
373
int status, exists;
374
static char hex[41];
375
376
- exists = has_sha1_file(sha1);
376
memcpy(hex, sha1_to_hex(sha1), 40);
377
if (len == 40 || !len)
378
return hex;
379
+ exists = has_sha1_file(sha1);
380
while (len < 40) {
381
unsigned char sha1_ret[20];
382
status = get_short_sha1(hex, len, sha1_ret, GET_SHA1_QUIETLY);