@matheusbsbs / matheus-bagliano / commits / 622bc93091

send-email: use "return;" not "return undef;" on error codepaths

All the callers of "ask", "extract_valid_address", and "validate_patch" subroutines assign the return values from them to a single scalar: $var = subr(...); and "return undef;" in these subroutine can safely be turned into a simpler "return;". Doing so will also future-proof a new caller that mistakenly does this: @foo = ask(...); if (@foo) { ... we got an answer ... } else { ... we did not ... } Note that we leave "return undef;" in validate_address on purpose, even though Perlcritic may complain. The primary "return" site of the function returns whatever is in the scalar variable $address, so it is pointless to change only the other "return undef;" to "return". The caller must be prepared to see an array with a single undef as the return value from this subroutine anyway. Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Ramkumar Ramachandra committed Mar 31, 2013 at 18:40 UTC 622bc9309155b05af1a0d85bfb643bf6280eba35

1 file changed +3 -3

git-send-email.perl

+3 -3

@@ -711,7 +711,7 @@ sub ask {

711 }

712 }

713 }

714 - return undef;

714 + return;

715 }

716

717 my %broken_encoding;

@@ -833,7 +833,7 @@ sub extract_valid_address {

833 # less robust/correct than the monster regexp in Email::Valid,

834 # but still does a 99% job, and one less dependency

835 return $1 if $address =~ /($local_part_regexp\@$domain_regexp)/;

836 - return undef;

836 + return;

837 }

838

839 sub extract_valid_address_or_die {

@@ -1484,7 +1484,7 @@ sub validate_patch {

1484 return "$.: patch contains a line longer than 998 characters";

1485 }

1486 }

1487 - return undef;

1487 + return;

1488 }

1489

1490 sub file_has_nonascii {