builtin/update-server-info: remove the_repository global variable
Remove the_repository global variable in favor of the repository argument that gets passed in "builtin/update-server-info.c". When `-h` is passed to the command outside a Git repository, the `run_builtin()` will call the `cmd_update_server_info()` function with `repo` set to NULL and then early in the function, "parse_options()" call will give the options help and exit, without having to consult much of the configuration file. So it is safe to omit reading the config when `repo` argument the caller gave us is NULL. Mentored-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Usman Akinyemi committed
Feb 10, 2025 at 23:40 UTC
62898b8f5e86b67dbc8f9092ae9ee0819823a0be
1 file changed
+4
-4
builtin/update-server-info.c
+4
-4
@@ -1,4 +1,3 @@
1
-#define USE_THE_REPOSITORY_VARIABLE
1
#include "builtin.h"
2
#include "config.h"
3
#include "gettext.h"
@@ -13,7 +12,7 @@ static const char * const update_server_info_usage[] = {
12
int cmd_update_server_info(int argc,
13
const char **argv,
14
const char *prefix,
16
- struct repository *repo UNUSED)
15
+ struct repository *repo)
16
{
17
int force = 0;
18
struct option options[] = {
@@ -21,11 +20,12 @@ int cmd_update_server_info(int argc,
20
OPT_END()
21
};
22
24
- git_config(git_default_config, NULL);
23
+ if (repo)
24
+ repo_config(repo, git_default_config, NULL);
25
argc = parse_options(argc, argv, prefix, options,
26
update_server_info_usage, 0);
27
if (argc > 0)
28
usage_with_options(update_server_info_usage, options);
29
30
- return !!update_server_info(the_repository, force);
30
+ return !!update_server_info(repo, force);
31
}