osxkeychain: clarify that we ignore unknown lines
Like in all the other credential helpers, the osxkeychain helper ignores unknown credential lines. Add a comment (a la the other helpers) to make it clear and explicit that this is the desired behaviour. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Matthew John Cheetham committed
Sep 22, 2022 at 16:59 UTC
630a6429a71118332ec3bc5aa58fce66df6ca5fa
1 file changed
+5
contrib/credential/osxkeychain/git-credential-osxkeychain.c
+5
@@ -159,6 +159,11 @@ static void read_credential(void)
159
username = xstrdup(v);
160
else if (!strcmp(buf, "password"))
161
password = xstrdup(v);
162
+ /*
163
+ * Ignore other lines; we don't know what they mean, but
164
+ * this future-proofs us when later versions of git do
165
+ * learn new lines, and the helpers are updated to match.
166
+ */
167
}
168
}
169