@matheusbsbs / matheus-bagliano / commits / 631f0f8c4b

ls-remote: do not send ref prefixes for patterns

Since b4be74105f (ls-remote: pass ref prefixes when requesting a remote's refs, 2018-03-15), "ls-remote foo" will pass "refs/heads/foo", "refs/tags/foo", etc to the transport code in an attempt to let the other side reduce the size of its advertisement. Unfortunately this is not correct, as ls-remote patterns do not follow the usual ref lookup rules, and are in fact tail-matched. So we could find "refs/heads/foo" or "refs/heads/a/much/deeper/foo" or even "refs/another/hierarchy/foo". Since we can't pass a prefix and there's not yet a v2 extension for matching wildcards, we must disable this feature to keep the same behavior as v1. Reported-by: Jon Simons <jon@jonsimons.org> Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jeff King committed Oct 31, 2018 at 00:24 UTC 631f0f8c4b3cf86df13534be40b8df56c2fc6dda
2 files changed +9 -8
builtin/ls-remote.c
-8
@@ -88,15 +88,7 @@ int cmd_ls_remote(int argc, const char **argv, const char *prefix)
88 int i;
89 pattern = xcalloc(argc, sizeof(const char *));
90 for (i = 1; i < argc; i++) {
91 - const char *glob;
91 pattern[i - 1] = xstrfmt("*/%s", argv[i]);
93 -
94 - glob = strchr(argv[i], '*');
95 - if (glob)
96 - argv_array_pushf(&ref_prefixes, "%.*s",
97 - (int)(glob - argv[i]), argv[i]);
98 - else
99 - expand_ref_prefix(&ref_prefixes, argv[i]);
92 }
93 }
94
t/t5512-ls-remote.sh
+9
@@ -304,4 +304,13 @@ test_expect_success 'ls-remote works outside repository' '
304 nongit git ls-remote dst.git
305 '
306
307 +test_expect_success 'ls-remote patterns work with all protocol versions' '
308 + git for-each-ref --format="%(objectname) %(refname)" \
309 + refs/heads/master refs/remotes/origin/master >expect &&
310 + git -c protocol.version=1 ls-remote . master >actual.v1 &&
311 + test_cmp expect actual.v1 &&
312 + git -c protocol.version=2 ls-remote . master >actual.v2 &&
313 + test_cmp expect actual.v2
314 +'
315 +
316 test_done