notes-merge: use ssize_t for write_in_full() return value
We store the return value of write_in_full() in a long, though the return is actually an ssize_t. This probably doesn't matter much in practice (since the buffer size is alredy an unsigned long), but it might if the size if between what can be represented in "long" and "unsigned long", and if your size_t is larger than a "long" (as it is on 64-bit Windows). Signed-off-by: Jeff King <peff@peff.net> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Sep 13, 2017 at 13:17 UTC
634eb82b1aa142e2743acd836447002fd9ebfa10
1 file changed
+1
-1
notes-merge.c
+1
-1
@@ -302,7 +302,7 @@ static void write_buf_to_worktree(const struct object_id *obj,
302
fd = xopen(path, O_WRONLY | O_EXCL | O_CREAT, 0666);
303
304
while (size > 0) {
305
- long ret = write_in_full(fd, buf, size);
305
+ ssize_t ret = write_in_full(fd, buf, size);
306
if (ret < 0) {
307
/* Ignore epipe */
308
if (errno == EPIPE)