@matheusbsbs / matheus-bagliano / commits / 63aa1d0cb7
Fork 0

git-gui: Do not munge conflict marker lines in a normal diff

Previously, conflict markers were highlighted in two ways: (1) They received a distinguishing color; and (2) they had the '+' removed at the beginning of the line. However, by doing (2), a hunk that contained conflict markers could not be staged or unstaged because the resulting patch was corrupted. With this change we no longer modify the diff text of a 2-way diff, so that "Stage Hunk" and friends work. Note that 3-way diff of a conflicted file is unaffected by this change, and '++' before conflict markers is still removed. But this has no negative impact because in this mode staging hunks or lines is disabled anyway. Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>

Johannes Sixt committed Oct 14, 2008 at 13:48 UTC 63aa1d0cb78e8fcf36ea2b8b65750d9a45d59f63
1 file changed -1
lib/diff.tcl
-1
@@ -377,7 +377,6 @@ proc read_diff {fd cont_info} {
377 {+} {
378 if {[regexp {^\+([<>]{7} |={7})} $line _g op]} {
379 set is_conflict_diff 1
380 - set line [string replace $line 0 0 { }]
380 set tags d$op
381 } else {
382 set tags d_+