convert: return early when not tracing
When Git adds a file requiring encoding conversion and tracing of encoding conversion is not requested via the GIT_TRACE_WORKING_TREE_ENCODING environment variable, the `trace_encoding()` function still allocates & prepares "human readable" copies of the file contents before and after conversion to show in the trace. This results in a high memory footprint and increased runtime without providing any user-visible benefit. This fix introduces an early exit from the `trace_encoding()` function when tracing is not requested, preventing unnecessary memory allocation and processing. Signed-off-by: D Harithamma <harithamma.d@ibm.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
D Harithamma committed
Jul 31, 2024 at 13:33 UTC
63ad8dbf169ec8e2b3cef40ff51499ee751a84a5
1 file changed
+3
convert.c
+3
@@ -322,6 +322,9 @@ static void trace_encoding(const char *context, const char *path,
322
struct strbuf trace = STRBUF_INIT;
323
int i;
324
325
+ if (!trace_want(&coe))
326
+ return;
327
+
328
strbuf_addf(&trace, "%s (%s, considered %s):\n", context, path, encoding);
329
for (i = 0; i < len && buf; ++i) {
330
strbuf_addf(