t5553: use local url for invalid fetch
We test how "fetch --set-upstream" behaves when given an invalid URL, using the bogus URL "http://nosuchdomain.example.com". But finding out that it is invalid requires an actual DNS lookup. Reduce our dependency on external factors by using an invalid local filesystem URL, which works just as well for our purposes. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Jun 26, 2024 at 16:54 UTC
63ec97faf7ab535fba4355fe9333fdc7ea61a7bc
1 file changed
+4
-4
t/t5553-set-upstream.sh
+4
-4
@@ -73,10 +73,10 @@ test_expect_success 'fetch --set-upstream main:other does not set the branch oth
73
check_config_missing other2
74
'
75
76
-test_expect_success 'fetch --set-upstream http://nosuchdomain.example.com fails with invalid url' '
76
+test_expect_success 'fetch --set-upstream ./does-not-exist fails with invalid url' '
77
# main explicitly not cleared, we check that it is not touched from previous value
78
clear_config other other2 &&
79
- test_must_fail git fetch --set-upstream http://nosuchdomain.example.com &&
79
+ test_must_fail git fetch --set-upstream ./does-not-exist &&
80
check_config main upstream refs/heads/other &&
81
check_config_missing other &&
82
check_config_missing other2
@@ -143,10 +143,10 @@ test_expect_success 'pull --set-upstream upstream tag does not set the tag' '
143
check_config_missing three
144
'
145
146
-test_expect_success 'pull --set-upstream http://nosuchdomain.example.com fails with invalid url' '
146
+test_expect_success 'pull --set-upstream ./does-not-exist fails with invalid url' '
147
# main explicitly not cleared, we check that it is not touched from previous value
148
clear_config other other2 three &&
149
- test_must_fail git pull --set-upstream http://nosuchdomain.example.com &&
149
+ test_must_fail git pull --set-upstream ./does-not-exist &&
150
check_config main upstream refs/heads/other &&
151
check_config_missing other &&
152
check_config_missing other2 &&