@matheusbsbs / matheus-bagliano / commits / 63fcbe00a6
Fork 0

gitweb: Do not use absolute font sizes

Avoid specifying font sizes in pixels, since that is just pure evil. Pointed out by Chris Riddoch. Note that this is pretty much just a proposal; I didn't test if everything fits perfectly right, but things seem to be pretty much okay. repo.or.cz uses it now as a test drive - if you find any visual quirks, please point them out, with a patch if possible since I'm total CSS noob and debugging CSS is an extremely painful experience for me. Note that this patch actually does change visual look of gitweb in Firefox with my resolution and default settings - everything is bigger and I can't explain the joy of actually seeing gitweb text that is in _readable_ size; also, my horizontal screen real estate feels better used now. But judging from the look of most modern webpages on the 'net, most people prefer reading the web with strained eyes and/or a magnifying glass (I wonder what species of scientists should look into this mystifying phenomenon) - so, please tell us what you think. Maybe we might want to get rid of absolute sizes other than font sizes in the CSS file too in the long term. Signed-off-by: Petr Baudis <pasky@suse.cz> Signed-off-by: Junio C Hamano <junkio@cox.net>

Petr Baudis committed May 9, 2007 at 03:41 UTC 63fcbe00a66d7cb7d8bce9a36120a19a809a33b8
1 file changed +9 -10
gitweb/gitweb.css
+9 -10
@@ -1,6 +1,5 @@
1 body {
2 font-family: sans-serif;
3 - font-size: 12px;
3 border: solid #d9d8d1;
4 border-width: 1px;
5 margin: 10px;
@@ -31,7 +30,7 @@ img.logo {
30 div.page_header {
31 height: 25px;
32 padding: 8px;
34 - font-size: 18px;
33 + font-size: 150%;
34 font-weight: bold;
35 background-color: #d9d8d1;
36 }
@@ -113,7 +112,7 @@ span.signoff {
112
113 div.log_link {
114 padding: 0px 8px;
116 - font-size: 10px;
115 + font-size: 70%;
116 font-family: sans-serif;
117 font-style: normal;
118 position: relative;
@@ -204,13 +203,13 @@ table.blame {
203
204 table.blame td {
205 padding: 0px 5px;
207 - font-size: 12px;
206 + font-size: 100%;
207 vertical-align: top;
208 }
209
210 th {
211 padding: 2px 5px;
213 - font-size: 12px;
212 + font-size: 100%;
213 text-align: left;
214 }
215
@@ -232,14 +231,14 @@ tr.dark:hover {
231
232 td {
233 padding: 2px 5px;
235 - font-size: 12px;
234 + font-size: 100%;
235 vertical-align: top;
236 }
237
238 td.link, td.selflink {
239 padding: 2px 5px;
240 font-family: sans-serif;
242 - font-size: 10px;
241 + font-size: 70%;
242 }
243
244 td.selflink {
@@ -416,7 +415,7 @@ div.index_include {
415 }
416
417 div.search {
419 - font-size: 12px;
418 + font-size: 100%;
419 font-weight: normal;
420 margin: 4px 8px;
421 position: absolute;
@@ -444,7 +443,7 @@ a.rss_logo {
443 background-color: #ff6600;
444 font-weight: bold;
445 font-family: sans-serif;
447 - font-size: 10px;
446 + font-size: 70%;
447 text-align: center;
448 text-decoration: none;
449 }
@@ -455,7 +454,7 @@ a.rss_logo:hover {
454
455 span.refs span {
456 padding: 0px 4px;
458 - font-size: 10px;
457 + font-size: 70%;
458 font-weight: normal;
459 border: 1px solid;
460 background-color: #ffaaff;