diff-lib: drop stale comment about advancing o->pos
The comment above oneway_diff() claims that the callback must advance o->pos to skip index entries it has already processed. That stopped being true in da165f470e (unpack-trees.c: prepare for looking ahead in the index, 2010-01-07), which moved that bookkeeping into unpack_trees(). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Jul 26, 2026 at 04:46 UTC
640177a987270564a8ef90cdc359677209fbe0fe
1 file changed
+1
-3
diff-lib.c
+1
-3
@@ -508,11 +508,9 @@ static void do_oneway_diff(struct unpack_trees_options *o,
508
* For diffing, the index is more important, and we only have a
509
* single tree.
510
*
511
- * We're supposed to advance o->pos to skip what we have already processed.
512
- *
511
* This wrapper makes it all more readable, and takes care of all
512
* the fairly complex unpack_trees() semantic requirements, including
515
- * the skipping, the path matching, the type conflict cases etc.
513
+ * the path matching, the type conflict cases etc.
514
*/
515
static int oneway_diff(const struct cache_entry * const *src,
516
struct unpack_trees_options *o)