t9100-git-svn-basic.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Elia Pinto committed
Jan 12, 2016 at 10:45 UTC
6560857550ce6be583b0ba20be777b4245ad3556
1 file changed
+4
-4
t/t9100-git-svn-basic.sh
+4
-4
@@ -265,18 +265,18 @@ test_expect_success 'able to dcommit to a subdirectory' "
265
git update-index --add d &&
266
git commit -m '/bar/d should be in the log' &&
267
git svn dcommit -i bar &&
268
- test -z \"\`git diff refs/heads/my-bar refs/remotes/bar\`\" &&
268
+ test -z \"\$(git diff refs/heads/my-bar refs/remotes/bar)\" &&
269
mkdir newdir &&
270
echo new > newdir/dir &&
271
git update-index --add newdir/dir &&
272
git commit -m 'add a new directory' &&
273
git svn dcommit -i bar &&
274
- test -z \"\`git diff refs/heads/my-bar refs/remotes/bar\`\" &&
274
+ test -z \"\$(git diff refs/heads/my-bar refs/remotes/bar)\" &&
275
echo foo >> newdir/dir &&
276
git update-index newdir/dir &&
277
git commit -m 'modify a file in new directory' &&
278
git svn dcommit -i bar &&
279
- test -z \"\`git diff refs/heads/my-bar refs/remotes/bar\`\"
279
+ test -z \"\$(git diff refs/heads/my-bar refs/remotes/bar)\"
280
"
281
282
test_expect_success 'dcommit should not fail with a touched file' '
@@ -295,7 +295,7 @@ test_expect_success 'able to set-tree to a subdirectory' "
295
git update-index d &&
296
git commit -m 'update /bar/d' &&
297
git svn set-tree -i bar HEAD &&
298
- test -z \"\`git diff refs/heads/my-bar refs/remotes/bar\`\"
298
+ test -z \"\$(git diff refs/heads/my-bar refs/remotes/bar)\"
299
"
300
301
test_expect_success 'git-svn works in a bare repository' '