CodingGuidelines: give deadline for "for (int i = 0; ..."
We raised the weather balloon to see if we can allow the construct in 44ba10d6 (revision: use C99 declaration of variable in for() loop, 2021-11-14), which was shipped as a part of Git v2.35. Document that fact in the coding guidelines, and more importantly, give ourselves a deadline to revisit and update. Let's declare that we will officially adopt the variable declaration in the initializaiton part of "for ()" statement this winter, unless we find that a platform we care about does not grok it. Signed-off-by: Junio C Hamano <gitster@pobox.com>
Junio C Hamano committed
Mar 30, 2022 at 17:09 UTC
6563706568b952d85c050b208b5301303d32810c
1 file changed
+4
-1
Documentation/CodingGuidelines
+4
-1
@@ -217,7 +217,10 @@ For C programs:
217
the first statement (i.e. -Wdeclaration-after-statement).
218
219
- Declaring a variable in the for loop "for (int i = 0; i < 10; i++)"
220
- is still not allowed in this codebase.
220
+ is still not allowed in this codebase. We are in the process of
221
+ allowing it by waiting to see that 44ba10d6 (revision: use C99
222
+ declaration of variable in for() loop, 2021-11-14) does not get
223
+ complaints. Let's revisit this around November 2022.
224
225
- NULL pointers shall be written as NULL, not as 0.
226