@matheusbsbs / matheus-bagliano / commits / 66142aa1f5
Fork 0

Quote all calls to GIT_CONF_APPEND_LINE

Not quoting macro arguments that contain other macros is a big no-no in Autoconf. It can break at any time. Signed-off-by: Pavel Roskin <proski@gnu.org> Signed-off-by: Junio C Hamano <junkio@cox.net>

Pavel Roskin committed Jul 15, 2006 at 01:29 UTC 66142aa1f53979a87678159a82734b0174d98070
1 file changed +12 -12
configure.ac
+12 -12
@@ -39,30 +39,30 @@ AC_MSG_NOTICE([CHECKS for libraries])
39 # Define NEEDS_SSL_WITH_CRYPTO if you need -lcrypto with -lssl (Darwin).
40 AC_CHECK_LIB([ssl], [SHA1_Init],[],
41 [AC_CHECK_LIB([crypto], [SHA1_INIT],
42 - GIT_CONF_APPEND_LINE(NEEDS_SSL_WITH_CRYPTO=YesPlease),
43 - GIT_CONF_APPEND_LINE(NO_OPENSSL=YesPlease))])
42 + [GIT_CONF_APPEND_LINE(NEEDS_SSL_WITH_CRYPTO=YesPlease)],
43 + [GIT_CONF_APPEND_LINE(NO_OPENSSL=YesPlease)])])
44 #
45 # Define NO_CURL if you do not have curl installed. git-http-pull and
46 # git-http-push are not built, and you cannot use http:// and https://
47 # transports.
48 AC_CHECK_LIB([curl], [curl_global_init],[],
49 -GIT_CONF_APPEND_LINE(NO_CURL=YesPlease))
49 +[GIT_CONF_APPEND_LINE(NO_CURL=YesPlease)])
50 #
51 # Define NO_EXPAT if you do not have expat installed. git-http-push is
52 # not built, and you cannot push using http:// and https:// transports.
53 AC_CHECK_LIB([expat], [XML_ParserCreate],[],
54 -GIT_CONF_APPEND_LINE(NO_EXPAT=YesPlease))
54 +[GIT_CONF_APPEND_LINE(NO_EXPAT=YesPlease)])
55 #
56 # Define NEEDS_LIBICONV if linking with libc is not enough (Darwin).
57 AC_CHECK_LIB([c], [iconv],[],
58 [AC_CHECK_LIB([iconv],[iconv],
59 - GIT_CONF_APPEND_LINE(NEEDS_LIBICONV=YesPlease),[])])
59 + [GIT_CONF_APPEND_LINE(NEEDS_LIBICONV=YesPlease)],[])])
60 #
61 # Define NEEDS_SOCKET if linking with libc is not enough (SunOS,
62 # Patrick Mauritz).
63 AC_CHECK_LIB([c], [socket],[],
64 [AC_CHECK_LIB([socket],[socket],
65 - GIT_CONF_APPEND_LINE(NEEDS_SOCKET=YesPlease),[])])
65 + [GIT_CONF_APPEND_LINE(NEEDS_SOCKET=YesPlease)],[])])
66
67
68 ## Checks for header files.
@@ -73,19 +73,19 @@ AC_MSG_NOTICE([CHECKS for typedefs, structures, and compiler characteristics])
73 #
74 # Define NO_D_INO_IN_DIRENT if you don't have d_ino in your struct dirent.
75 AC_CHECK_MEMBER(struct dirent.d_ino,[],
76 -GIT_CONF_APPEND_LINE(NO_D_INO_IN_DIRENT=YesPlease),
76 +[GIT_CONF_APPEND_LINE(NO_D_INO_IN_DIRENT=YesPlease)],
77 [#include <dirent.h>])
78 #
79 # Define NO_D_TYPE_IN_DIRENT if your platform defines DT_UNKNOWN but lacks
80 # d_type in struct dirent (latest Cygwin -- will be fixed soonish).
81 AC_CHECK_MEMBER(struct dirent.d_type,[],
82 -GIT_CONF_APPEND_LINE(NO_D_TYPE_IN_DIRENT=YesPlease),
82 +[GIT_CONF_APPEND_LINE(NO_D_TYPE_IN_DIRENT=YesPlease)],
83 [#include <dirent.h>])
84 #
85 # Define NO_SOCKADDR_STORAGE if your platform does not have struct
86 # sockaddr_storage.
87 AC_CHECK_TYPE(struct sockaddr_storage,[],
88 -GIT_CONF_APPEND_LINE(NO_SOCKADDR_STORAGE=YesPlease),
88 +[GIT_CONF_APPEND_LINE(NO_SOCKADDR_STORAGE=YesPlease)],
89 [#include <netinet/in.h>])
90
91
@@ -95,15 +95,15 @@ AC_MSG_NOTICE([CHECKS for library functions])
95 #
96 # Define NO_STRCASESTR if you don't have strcasestr.
97 AC_CHECK_FUNC(strcasestr,[],
98 -GIT_CONF_APPEND_LINE(NO_STRCASESTR=YesPlease))
98 +[GIT_CONF_APPEND_LINE(NO_STRCASESTR=YesPlease)])
99 #
100 # Define NO_STRLCPY if you don't have strlcpy.
101 AC_CHECK_FUNC(strlcpy,[],
102 -GIT_CONF_APPEND_LINE(NO_STRLCPY=YesPlease))
102 +[GIT_CONF_APPEND_LINE(NO_STRLCPY=YesPlease)])
103 #
104 # Define NO_SETENV if you don't have setenv in the C library.
105 AC_CHECK_FUNC(setenv,[],
106 -GIT_CONF_APPEND_LINE(NO_SETENV=YesPlease))
106 +[GIT_CONF_APPEND_LINE(NO_SETENV=YesPlease)])
107 #
108 # Define NO_MMAP if you want to avoid mmap.
109 #