doc: note that AT&T ksh does not work with our test suite
The scripted Porcelain commands do not allow use of "local" because it is not universally supported, but we use it liberally in our test scripts, which means some POSIX compliant shells (like "ksh93") can not be used to run our tests. Document the status quo, to help the next person who gets perplexed seeing our tests fail. Signed-off-by: Junio C Hamano <gitster@pobox.com>
Junio C Hamano committed
Jul 15, 2024 at 08:05 UTC
67be8c4de5255efd95c48c9ddd6cd8537fbf03d1
1 file changed
+2
-2
Documentation/CodingGuidelines
+2
-2
@@ -185,8 +185,8 @@ For shell scripts specifically (not exhaustive):
185
186
- Even though "local" is not part of POSIX, we make heavy use of it
187
in our test suite. We do not use it in scripted Porcelains, and
188
- hopefully nobody starts using "local" before they are reimplemented
189
- in C ;-)
188
+ hopefully nobody starts using "local" before all shells that matter
189
+ support it (notably, ksh from AT&T Research does not support it yet).
190
191
- Some versions of shell do not understand "export variable=value",
192
so we write "variable=value" and then "export variable" on two