refs.c: abort ref search if ref array is empty
The bsearch() implementation on IRIX 6.5 segfaults if it is passed NULL for the base array argument even if number-of-elements is zero. So, let's work around it by detecting an empty array and aborting early. This is a useful optimization in its own right anyway, since we avoid a useless allocation and initialization of the ref_entry when the ref array is empty. Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Brandon Casey committed
Oct 7, 2011 at 22:20 UTC
687296960d774a45df31df7bc371d01106a6f6b7
1 file changed
+3
refs.c
+3
@@ -110,6 +110,9 @@ static struct ref_entry *search_ref_array(struct ref_array *array, const char *n
110
if (name == NULL)
111
return NULL;
112
113
+ if (!array->nr)
114
+ return NULL;
115
+
116
len = strlen(name) + 1;
117
e = xmalloc(sizeof(struct ref_entry) + len);
118
memcpy(e->name, name, len);