bisect--helper: retire `--bisect-write` subcommand

The `--bisect-write` subcommand is no longer used from the git-bisect.sh shell script. Instead the function `bisect_write()` is directly called from the C implementation. Mentored-by: Lars Schneider <larsxschneider@gmail.com> Mentored-by: Christian Couder <chriscool@tuxfamily.org> Mentored-by: Johannes Schindelin <Johannes.Schindelin@gmx.de> Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com> Signed-off-by: Tanushree Tumane <tanushreetumane@gmail.com> Signed-off-by: Miriam Rubio <mirucam@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Pranit Bauva committed Feb 3, 2021 at 22:54 UTC 68efed8c8a43ad95f4e517ea60034179418dd8bc
1 file changed -10
builtin/bisect--helper.c
-10
@@ -21,7 +21,6 @@ static GIT_PATH_FUNC(git_path_bisect_first_parent, "BISECT_FIRST_PARENT")
21
22 static const char * const git_bisect_helper_usage[] = {
23 N_("git bisect--helper --bisect-reset [<commit>]"),
24 - N_("git bisect--helper --bisect-write [--no-log] <state> <revision> <good_term> <bad_term>"),
24 N_("git bisect--helper --bisect-check-and-set-terms <command> <good_term> <bad_term>"),
25 N_("git bisect--helper --bisect-next-check <good_term> <bad_term> [<term>]"),
26 N_("git bisect--helper --bisect-terms [--term-good | --term-old | --term-bad | --term-new]"),
@@ -998,7 +997,6 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
997 {
998 enum {
999 BISECT_RESET = 1,
1001 - BISECT_WRITE,
1000 CHECK_AND_SET_TERMS,
1001 BISECT_NEXT_CHECK,
1002 BISECT_TERMS,
@@ -1014,8 +1012,6 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
1012 struct option options[] = {
1013 OPT_CMDMODE(0, "bisect-reset", &cmdmode,
1014 N_("reset the bisection state"), BISECT_RESET),
1017 - OPT_CMDMODE(0, "bisect-write", &cmdmode,
1018 - N_("write out the bisection state in BISECT_LOG"), BISECT_WRITE),
1015 OPT_CMDMODE(0, "check-and-set-terms", &cmdmode,
1016 N_("check and set terms in a bisection state"), CHECK_AND_SET_TERMS),
1017 OPT_CMDMODE(0, "bisect-next-check", &cmdmode,
@@ -1052,12 +1048,6 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
1048 if (argc > 1)
1049 return error(_("--bisect-reset requires either no argument or a commit"));
1050 return !!bisect_reset(argc ? argv[0] : NULL);
1055 - case BISECT_WRITE:
1056 - if (argc != 4 && argc != 5)
1057 - return error(_("--bisect-write requires either 4 or 5 arguments"));
1058 - set_terms(&terms, argv[3], argv[2]);
1059 - res = bisect_write(argv[0], argv[1], &terms, nolog);
1060 - break;
1051 case CHECK_AND_SET_TERMS:
1052 if (argc != 3)
1053 return error(_("--check-and-set-terms requires 3 arguments"));