for_each_reflog_ent_reverse: turn leftover check into assertion
Our loop should always process all lines, even if we hit the beginning of the file. We have a conditional after the loop ends to double-check that there is nothing left and to process it. But this should never happen, and is a sign of a logic bug in the loop. Let's turn it into a BUG assertion. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Dec 4, 2014 at 20:32 UTC
69216bf72be2be4f8aa932324b3145d3f395cdc6
1 file changed
+1
-1
refs.c
+1
-1
@@ -3136,7 +3136,7 @@ int for_each_reflog_ent_reverse(const char *refname, each_reflog_ent_fn fn, void
3136
3137
}
3138
if (!ret && sb.len)
3139
- ret = show_one_reflog_ent(&sb, fn, cb_data);
3139
+ die("BUG: reverse reflog parser had leftover data");
3140
3141
fclose(logfp);
3142
strbuf_release(&sb);