ssh signing: signal an error with a negative return value

The other backend for the sign_buffer() function followed our usual "an error is signalled with a negative return" convention, but the SSH signer did not. Even though we already fixed the caller that assumed only a negative return value is an error, tighten the callee to signal an error with a negative return as well. This way, the callees will be strict on what they produce, while the callers will be lenient in what they accept. Signed-off-by: Junio C Hamano <gitster@pobox.com>

Junio C Hamano committed Feb 7, 2024 at 21:29 UTC 6931049c32ca0271ba95dcd0f197100d22c8d844
1 file changed +1 -1
gpg-interface.c
+1 -1
@@ -1088,7 +1088,7 @@ static int sign_buffer_ssh(struct strbuf *buffer, struct strbuf *signature,
1088 if (strstr(signer_stderr.buf, "usage:"))
1089 error(_("ssh-keygen -Y sign is needed for ssh signing (available in openssh version 8.2p1+)"));
1090
1091 - error("%s", signer_stderr.buf);
1091 + ret = error("%s", signer_stderr.buf);
1092 goto out;
1093 }
1094