t5530: check protocol response for "not our ref"
Back in 9f9aa76130 (upload-pack: Improve error message when bad ref requested, 2010-07-31), we added a test to make sure that we die with a sensible message when the client asks for an object we don't have. Much later, in bdb31eada7 (upload-pack: report "not our ref" to client, 2017-02-23), we started reporting that information via an "ERR" line in the protocol. Let's check that part, as well. While we're touching this test, let's drop the "-q" on the grep calls. Our usual test style just relies on --verbose to control output. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Apr 13, 2019 at 01:53 UTC
6963a4e4e1fe7b4668a954eeb05feab98d625ddc
1 file changed
+3
-2
t/t5530-upload-pack-error.sh
+3
-2
@@ -62,8 +62,9 @@ test_expect_success 'upload-pack error message when bad ref requested' '
62
printf "0045want %s multi_ack_detailed\n00000009done\n0000" \
63
"deadbeefdeadbeefdeadbeefdeadbeefdeadbeef" >input &&
64
test_must_fail git upload-pack . <input >output 2>output.err &&
65
- grep -q "not our ref" output.err &&
66
- ! grep -q multi_ack_detailed output.err
65
+ grep "not our ref" output.err &&
66
+ grep "ERR" output &&
67
+ ! grep multi_ack_detailed output.err
68
'
69
70
test_expect_success 'upload-pack fails due to error in pack-objects enumeration' '